I think the C code replacing the ML code for Unix.execute does not quite do what the ML code used to. Specifically the execve call here https://github.com/polyml/polyml/blob/master/libpolyml/unix_specific.cpp#L20... does not pass the cmd as the first argument, whereas the ML version did. This is a user-visible change in the API that was probably unintended.
On 19/06/2021 15:17, Ramana Kumar wrote:
I think the C code replacing the ML code for Unix.execute does not quite do what the ML code used to. Specifically the execve call here https://github.com/polyml/polyml/blob/master/libpolyml/unix_specific.cpp#L20... does not pass the cmd as the first argument, whereas the ML version did. This is a user-visible change in the API that was probably unintended.
Wasn't this fixed in b3855a5 ? That fix is included in the fixes-5.8.2 branch.
David
It looks like the fix in b3855a5 is to the ML version of the library method. But on master we are now using a C version of the library method, and it does not have a corresponding fix (nor on the fixes branch, as far as I can see).
On Mon, 21 Jun 2021 at 11:16, David Matthews <David.Matthews at prolingua.co.uk> wrote:
On 19/06/2021 15:17, Ramana Kumar wrote:
I think the C code replacing the ML code for Unix.execute does not quite
do
what the ML code used to. Specifically the execve call here
https://github.com/polyml/polyml/blob/master/libpolyml/unix_specific.cpp#L20...
does not pass the cmd as the first argument, whereas the ML version did. This is a user-visible change in the API that was probably unintended.
Wasn't this fixed in b3855a5 ? That fix is included in the fixes-5.8.2 branch.
David _______________________________________________ polyml mailing list polyml at inf.ed.ac.uk http://lists.inf.ed.ac.uk/mailman/listinfo/polyml
Apologies - I misread the code. I think you're right that it's fixed. I'll try using the fixes branch.
On Mon, 21 Jun 2021 at 14:45, Ramana Kumar <Ramana.Kumar at cl.cam.ac.uk> wrote:
It looks like the fix in b3855a5 is to the ML version of the library method. But on master we are now using a C version of the library method, and it does not have a corresponding fix (nor on the fixes branch, as far as I can see).
On Mon, 21 Jun 2021 at 11:16, David Matthews < David.Matthews at prolingua.co.uk> wrote:
On 19/06/2021 15:17, Ramana Kumar wrote:
I think the C code replacing the ML code for Unix.execute does not
quite do
what the ML code used to. Specifically the execve call here
https://github.com/polyml/polyml/blob/master/libpolyml/unix_specific.cpp#L20...
does not pass the cmd as the first argument, whereas the ML version did. This is a user-visible change in the API that was probably unintended.
Wasn't this fixed in b3855a5 ? That fix is included in the fixes-5.8.2 branch.
David _______________________________________________ polyml mailing list polyml at inf.ed.ac.uk http://lists.inf.ed.ac.uk/mailman/listinfo/polyml
-
David.Matthews＠prolingua.co.uk -
Ramana.Kumar＠cl.cam.ac.uk