V2hpbGUgdXBkYXRpbmcgbXkgRXh0ZW5kZWQgQmFzaXMgbGlicmFyeQooaHR0cDovL21sdG9uLm9y Zy9jZ2ktYmluL3ZpZXdzdm4uY2dpL21sdG9ubGliL3RydW5rL2NvbS9zc2gvZXh0ZW5kZWQtYmFz aXMvdW5zdGFibGUvKQp0byBjb21waWxlIHdpdGggUG9seS9NTCwgSSBmaXhlZCBzb21lIGlzc3Vl cyBpbiBQb2x5L01MJ3MgQmFzaXMKbGlicmFyeSBpbXBsZW1lbnRhdGlvbjoKCi0gSSBmaXhlZCB0 aGUgUkVBTCBzaWduYXR1cmUsIHdoaWNoIGRpZCBub3QgY29ycmVzcG9uZCB0byB0aGUgUmVhbApz dHJ1Y3R1cmUuICBJIGFsc28gc2VhbGVkIHRoZSBSZWFsIHN0cnVjdHVyZSB3aXRoIHRoZSBSRUFM IHNpZ25hdHVyZQp0byBhdm9pZCBwcm9ibGVtcyBsaWtlIHRoYXQgaW4gdGhlIGZ1dHVyZS4KCi0g SSBhZGRlZCB0aGUgbWlzc2luZyBURVhUX0lPIHNpZ25hdHVyZS4gIEkgaGF2ZW4ndCBjaGVja2Vk IHdoZXRoZXIgaXQKY29uZm9ybXMgdG8gdGhlIEJhc2lzIGxpYnJhcnkgc3BlYywgYnV0IGF0IGxl YXN0IHRoZXJlIG5vdyBpcyBhClRFWFRfSU8gc2lnbmF0dXJlICh3aGljaCBpcyBuZWVkZWQgYnkg bXkgbGlicmFyeSkuCgotIEkgZml4ZWQgc29tZSBzcGVjaWZpY2F0aW9ucyBpbiB0aGUgQ0hBUiBh bmQgU1RSSU5HIHNpZ25hdHVyZXMgdG8KY29uZm9ybSB0byB0aGUgQmFzaXMgc3BlYywgd2l0aCB0 aGUgZXhjZXB0aW9uIG9mIHRoZSBTVFJJTkcuc2Nhbgp2YWx1ZSwgd2hpY2ggc2VlbXMgdG8gYmUg c3BlY2lmaWVkIGluY29ycmVjdGx5IGluIHRoZSBCYXNpcyBzcGVjIChzZWUKaHR0cDovL21sdG9u Lm9yZy9waXBlcm1haWwvbWx0b24vMjAwNy1NYXJjaC8wMjk3MDAuaHRtbCkuCgpBdHRhY2hlZCBp cyBhIHBhdGNoIG9mIHRoZXNlIGNoYW5nZXMuCgotVmVzYSBLYXJ2b25lbgotLS0tLS0tLS0tLS0t LSBuZXh0IHBhcnQgLS0tLS0tLS0tLS0tLS0KQSBub24tdGV4dCBhdHRhY2htZW50IHdhcyBzY3J1 YmJlZC4uLgpOYW1lOiBiYXNpcy1maXhlcy5wYXRjaApUeXBlOiB0ZXh0L3gtZGlmZgpTaXplOiAx MDgyNCBieXRlcwpEZXNjOiBub3QgYXZhaWxhYmxlClVybCA6IGh0dHA6Ly9saXN0cy5pbmYuZWQu YWMudWsvbWFpbG1hbi9wcml2YXRlL3BvbHltbC9hdHRhY2htZW50cy8yMDA3MTEwNi9kMTY2MjRk Yy9iYXNpcy1maXhlcy5iaW4K
Vesa Karvonen wrote:
While updating my Extended Basis library (http://mlton.org/cgi-bin/viewsvn.cgi/mltonlib/trunk/com/ssh/extended-basis/u...) to compile with Poly/ML, I fixed some issues in Poly/ML's Basis library implementation:
- I fixed the REAL signature, which did not correspond to the Real
structure. I also sealed the Real structure with the REAL signature to avoid problems like that in the future.
- I added the missing TEXT_IO signature. I haven't checked whether it
conforms to the Basis library spec, but at least there now is a TEXT_IO signature (which is needed by my library).
- I fixed some specifications in the CHAR and STRING signatures to
conform to the Basis spec, with the exception of the STRING.scan value, which seems to be specified incorrectly in the Basis spec (see http://mlton.org/pipermail/mlton/2007-March/029700.html).
Attached is a patch of these changes.
Thanks for that. I've applied those patches with one exception. Your patch removed Real.realRound and I've left it in. I assume that was an oversight.
David.